fix: Set the combinedScore value to the locationScore if there is no combinedScore #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garobrik
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will prevent the new backend from crashing with the 1.2 frontend
Per this slack thread: https://tech-matters.slack.com/archives/C0376RCCXD2/p1752100638887979
This will allow the new global-enabled backend to work (mostly) with the old frontend, and with the new frontend.
The only thing that I'm aware of that doesn't work is that now on 1.2 it looks like global sites work -- until you try to view a soil match's details, and then it crashes because global matches don't have LCC but the client expects LCC.
Related Issues
I haven't made an issue, but could if that's useful :)