poc: Generate thumbnail with playwright #494
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josebui
requested review from
paulschreiber,
garobrik,
JeancarloBarrios and
david-code
josebui
commented
May 10, 2023
| }); | ||
| const page = await context.newPage(); | ||
|
|
||
| await context.addCookies([ |
There was a problem hiding this comment.
Potentially we could inpersonate a user to get a thumbnail of their private data, it seems that this is not needed for the first iteration
|
|
||
| fs.writeFile(outputPath, screenshotBuffer, (err) => { | ||
| if (err) { | ||
| console.error('Error saving screenshot:', err); |
There was a problem hiding this comment.
Suggested change
| console.error('Error saving screenshot:', err); | |
| console.error('Error saving screenshot to ${outputPath}:', err); |
Comment on lines
+38
to
+46
| // sharp(screenshotBuffer) | ||
| // .resize(200, 150) // Set the thumbnail dimensions here | ||
| // .toFile(outputPath, (err, info) => { | ||
| // if (err) { | ||
| // console.error('Error generating thumbnail:', err); | ||
| // } else { | ||
| // console.log('Thumbnail generated successfully:', info); | ||
| // } | ||
| // }); |
There was a problem hiding this comment.
question: what's this for? can it be removed?
| }, | ||
| ]); | ||
|
|
||
| await page.goto('https://app.staging.terraso.net/tools/story-maps/f2xs943/ecuador-2'); // Replace with the URL of the website you want to capture |
There was a problem hiding this comment.
Suggested change
| await page.goto('https://app.staging.terraso.net/tools/story-maps/f2xs943/ecuador-2'); // Replace with the URL of the website you want to capture | |
| await page.goto(pageUrl); |
| const sharp = require('sharp'); | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
There was a problem hiding this comment.
Suggested change
| const pageUrl = 'https://app.staging.terraso.net/tools/story-maps/f2xs943/ecuador-2'; // Replace with the URL of the website you want to capture | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description