Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SA1019] Change deprecated GRPC Middleware Chain functions #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SA1019] Change deprecated GRPC Middleware Chain functions #580

wants to merge 1 commit into from
+2 −3

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Aug 25, 2023 •
edited
Loading

To fix SA1019 static check error given by Dependable Bot at 579: , we:
Change WithStreamServerChain to grpc.ChainStreamInterceptor Change WithUnaryServerChain to grpc.ChainUnaryInterceptor

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 25, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@khrm
Copy link
Contributor Author

khrm commented Aug 25, 2023

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 25, 2023
@khrm
Copy link
Contributor Author

khrm commented Aug 25, 2023

/hold

Let's merge this after the release of v0.8.0

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2023
@khrm khrm mentioned this pull request Aug 25, 2023
Open
@khrm
[SA1019] Change deprecated GRPC Middleware Chain functions
10c4669 
To fix SA1019 static check error, we:
Change WithStreamServerChain to grpc.ChainStreamInterceptor
Change WithUnaryServerChain to grpc.ChainUnaryInterceptor
khrm
khrm commented Sep 8, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

@dibyom dibyom Awaiting requested review from dibyom

Assignees
No one assigned
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khrm @tekton-robot