Update building-win-x64.md#26424
Open
CaledoniaProject wants to merge 1 commit intotelegramdesktop:devfrom
Open
Update building-win-x64.md#26424CaledoniaProject wants to merge 1 commit intotelegramdesktop:devfrom
CaledoniaProject wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Fix issues mentioned here telegramdesktop#26414
Contributor
|
I'm not sure it's a good idea given that you haven't confirmed it's the source of your problem |
Collaborator
|
oh i have seen people having this issue on trinitycore too, and yes, installing separate cmake instead C++ CMake tools for Windows fixes a lot of issues. |
Contributor
|
Maybe they have updated their cmake with time though? Haven't seen such reports for a long time. |
ilya-fedin
reviewed
Jun 13, 2024
| ## Prepare folder | ||
|
|
||
| The build is done in **Visual Studio 2022** with **10.0.22000.0** SDK version. | ||
| The build is done in **Visual Studio 2022** with **10.0.22000.0** SDK version, do not install **C++ CMake tools for Windows** |
Contributor
There was a problem hiding this comment.
So I have removed manually installed cmake altogether and switched to cmake from Visual Studio. No issues. This line doesn't need any changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues mentioned here #26414