Skip to content

fix/THQ-4188 Support prop drilling in HTML export #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix/THQ-4188 Support prop drilling in HTML export #962

merged 1 commit into from
Mar 24, 2025

Conversation

vladgrecu
Copy link
Member

@vladgrecu
Copy link
Member Author

@JayaKrishnaNamburu think you can check it out?
I remember you assessing this to be a bigger chunk of work but I found a way to do it pretty fast.
Any concerns you might have?

JayaKrishnaNamburu
JayaKrishnaNamburu approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@JayaKrishnaNamburu JayaKrishnaNamburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flattening for children seems to work as expected. I tested by passing a page prop to a component, that is passing to another child component here

project.json

Seems to work as expected and the tests are passing. Nice work and fix 🙌
Screenshot 2025-03-24 at 9 02 11 PM

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit eeae9a6 into development Mar 24, 2025
1 check passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the fix/THQ-4188-html-prop-drilling branch March 24, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayaKrishnaNamburu JayaKrishnaNamburu JayaKrishnaNamburu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladgrecu @JayaKrishnaNamburu