Skip to content

Adjust target size of interactive elements to meet accessibility criteria #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2023

Conversation

epetrow
Copy link
Contributor

@epetrow epetrow commented May 15, 2023

@epetrow epetrow added this to the 2023.2 milestone May 15, 2023
@epetrow epetrow self-assigned this May 15, 2023
@epetrow epetrow force-pushed the minimum-target-size branch 9 times, most recently from 202ffb7 to 0ac06e6 Compare May 19, 2023 14:18
@epetrow epetrow force-pushed the minimum-target-size branch 2 times, most recently from c93b1c3 to 5eccb3e Compare June 1, 2023 09:31
@epetrow epetrow marked this pull request as ready for review June 1, 2023 09:40
@epetrow epetrow requested a review from a team as a code owner June 1, 2023 09:40
@inikolova
Copy link
Contributor

I observed the following misalignments - maybe some of them are expected, however could we double check :)

@epetrow epetrow force-pushed the minimum-target-size branch from 4ab4280 to ae81844 Compare June 13, 2023 11:23
@epetrow
Copy link
Contributor Author

epetrow commented Jun 13, 2023

I observed the following misalignments - maybe some of them are expected, however could we double check :)

I synced with @dmanova and agreed on the following:

  • DropDownTree, MultiSelectTree - we will add additional inline padding to the TreeView inside the popup ( we were already overriding it's padding in the layout.scss of the DropDownTree )
  • PivotGrid - the changes are expected, no changes need to be applied for this case
  • Spreadsheet's filter menu - same as the first case, since we were already modifying the padding of the TreeView, additional inline padding will be added

@epetrow epetrow requested a review from inikolova June 13, 2023 11:41
@Juveniel Juveniel self-requested a review June 13, 2023 13:03
@epetrow epetrow marked this pull request as draft June 13, 2023 15:09
@epetrow epetrow force-pushed the minimum-target-size branch 3 times, most recently from 3f2d44d to a78ff61 Compare June 14, 2023 10:57
@epetrow epetrow marked this pull request as ready for review June 14, 2023 11:17
@epetrow epetrow requested a review from JoomFX June 15, 2023 08:23
@Juveniel Juveniel force-pushed the minimum-target-size branch 2 times, most recently from c957dbc to 7207cba Compare June 16, 2023 13:38
@Juveniel Juveniel force-pushed the minimum-target-size branch from 76152ce to 08c98f1 Compare June 16, 2023 13:51
@Juveniel Juveniel modified the milestones: 2023.2, 2023.3 Jun 16, 2023
@Juveniel Juveniel merged commit 770cdee into develop Jun 16, 2023
@Juveniel Juveniel deleted the minimum-target-size branch June 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants