Skip to content

Update vars descriptions #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 20, 2023
Merged

Update vars descriptions #4511

merged 21 commits into from
Jun 20, 2023

Conversation

inikolova
Copy link
Contributor

@inikolova inikolova commented May 30, 2023

https://github.com/telerik/kendo-themes-private/issues/92

Note: Some of the components listed in the issue above don't have dedicated folders with variables and styles -> they rely on the styles of other components. Below is a list with them:

  • MultiSelectTree - uses the styles for input, button, chip, popup, treeview;
  • DateInput - uses the styles for k-input;
  • ChipList - uses the styles for the chip. Its specific variables are only for the sizes -> https://github.com/telerik/kendo-themes/blob/develop/packages/default/scss/chip/_variables.scss#L173
  • ColorPicker - uses the styles for the colorEditor;
  • FlatColorPicker - uses the styles for the colorEditor;
  • MultiColumnComboBox - uses the styles for input, button, popup, data table;
  • SearchBox - uses the styles for the input;

CheckboxGroup and RadioButtonGroup variables have been documented with these commits:

@inikolova inikolova added the Documentation Improvements or additions to documentation label May 30, 2023
@inikolova inikolova requested a review from a team as a code owner May 30, 2023 10:08
@inikolova inikolova self-assigned this May 30, 2023
@inikolova inikolova marked this pull request as draft May 30, 2023 10:08
@inikolova inikolova force-pushed the update-vars-descriptions branch 3 times, most recently from 0dac04f to b437657 Compare June 7, 2023 13:27
@inikolova inikolova force-pushed the update-vars-descriptions branch from b2d1fd8 to 96a5be3 Compare June 8, 2023 15:22
@inikolova inikolova marked this pull request as ready for review June 9, 2023 07:57
@inikolova inikolova requested a review from a team June 9, 2023 07:58
@epetrow epetrow added this to the 2023.3 milestone Jun 9, 2023
Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I made some minor changes in the variable descriptions and in some of the component names for the Default theme. You can propagate them to the rest of the themes as well.

@inikolova inikolova force-pushed the update-vars-descriptions branch 2 times, most recently from 49f3eff to 4b56ff4 Compare June 14, 2023 15:18
@inikolova inikolova force-pushed the update-vars-descriptions branch from 5a0262d to aa0acd8 Compare June 19, 2023 15:01
@Juveniel Juveniel merged commit dc387b2 into develop Jun 20, 2023
@Juveniel Juveniel deleted the update-vars-descriptions branch June 20, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants