-
Notifications
You must be signed in to change notification settings - Fork 70
Update vars descriptions #4511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update vars descriptions #4511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dac04f
to
b437657
Compare
b2d1fd8
to
96a5be3
Compare
yordan-mitev
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I made some minor changes in the variable descriptions and in some of the component names for the Default theme. You can propagate them to the rest of the themes as well.
49f3eff
to
4b56ff4
Compare
Juveniel
approved these changes
Jun 16, 2023
5a0262d
to
aa0acd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/telerik/kendo-themes-private/issues/92
Note: Some of the components listed in the issue above don't have dedicated folders with variables and styles -> they rely on the styles of other components. Below is a list with them:
CheckboxGroup and RadioButtonGroup variables have been documented with these commits:
CheckboxGroup - c2bd9d8#diff-4fa806c700a6f99c7de8355c97b6bf7252345d54803cbbfed7a83315b5bb6f4bR174
RadioButtonGroup - c2bd9d8#diff-762fcabdeabea89ff3a9cf344907886b611cc1bed8614c356698d18d56bea3ccR166