Unify rendering Skeleton #4531
Merged
Unify rendering Skeleton #4531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikostadinov
force-pushed
the
unify-rendering-skeleton
branch
from
071b8ff to
21d0187
Compare
epetrow
reviewed
Jun 13, 2023
|
Also rename the last commit to |
kikostadinov
force-pushed
the
unify-rendering-skeleton
branch
2 times, most recently
from
3555190 to
db6744a
Compare
kikostadinov
force-pushed
the
unify-rendering-skeleton
branch
from
641529c to
39b0fc9
Compare
Juveniel
reviewed
Jul 7, 2023
kikostadinov
force-pushed
the
unify-rendering-skeleton
branch
from
be5e752 to
ca01d95
Compare
epetrow
force-pushed
the
unify-rendering-skeleton
branch
from
2135973 to
d0c1cef
Compare
JoomFX
suggested changes
Jul 13, 2023
There was a problem hiding this comment.
Regarding this commit - please replace the Skeleton rendering (<span className="k-skeleton k-skeleton-text k-skeleton-pulse"></span>) with the actual component (<Skeleton />).
kikostadinov
force-pushed
the
unify-rendering-skeleton
branch
from
25649b2 to
6c94f08
Compare
JoomFX
approved these changes
Jul 14, 2023
epetrow
added
C: Skeleton
Enhancement
Juveniel
reviewed
Jul 19, 2023
epetrow
force-pushed
the
unify-rendering-skeleton
branch
from
9980f28 to
5bbb74e
Compare
epetrow
force-pushed
the
unify-rendering-skeleton
branch
from
5fefde9 to
b037326
Compare
epetrow
force-pushed
the
unify-rendering-skeleton
branch
from
db692e6 to
2928c85
Compare
Juveniel
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/telerik/kendo-themes-private/issues/142