Unify Chat rendering #4568
Merged
Unify Chat rendering #4568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epetrow
force-pushed
the
unify-rendering-chat
branch
7 times, most recently
from
e53680a to
92ba30b
Compare
Juveniel
added
Enhancement
epetrow
force-pushed
the
unify-rendering-chat
branch
4 times, most recently
from
203e5b8 to
278632a
Compare
|
Almost everything looks good to me. However, I have concerns with align attachments based on user who attaches them- this is not an universal solution and will work only in specific cases (for example it won't work in Angular, as there is an additional host element). My suggestion is to add an additional class for the alt attachments and use it in the CSS selector. |
epetrow
force-pushed
the
unify-rendering-chat
branch
from
91fea9d to
ed64b88
Compare
epetrow
force-pushed
the
unify-rendering-chat
branch
from
3cbd048 to
2d49dea
Compare
Juveniel
force-pushed
the
unify-rendering-chat
branch
from
5836ba7 to
2431dda
Compare
Juveniel
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/telerik/kendo-themes-private/issues/140
Targets first bullet from #1929 (comment), second one needs design.