Unify rendering for the PDFViewer #4629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magdalenaan
force-pushed
the
pdf-viewer-aliases
branch
2 times, most recently
from
a6f82f7 to
d309b3a
Compare
epetrow
reviewed
Jul 25, 2023
tests/_output/bootstrap/pdf-viewer/pdf-viewer-search-panel-jquery.png
Outdated
Show resolved
Hide resolved
|
Changes can be merged after updating PDFViewer rendering in the jQuery |
magdalenaan
force-pushed
the
pdf-viewer-aliases
branch
from
d309b3a to
eb212d0
Compare
Juveniel
force-pushed
the
pdf-viewer-aliases
branch
2 times, most recently
from
9ba9d56 to
fd24e9f
Compare
Juveniel
changed the title
Juveniel
force-pushed
the
pdf-viewer-aliases
branch
from
06c3a62 to
14ef601
Compare
epetrow
approved these changes
Sep 12, 2023
| @@ -25,6 +25,9 @@ $kendo-pdf-viewer-page-text: $kendo-component-text !default; | |||
| $kendo-pdf-viewer-page-border: $kendo-component-border !default; | |||
| $kendo-pdf-viewer-page-shadow: 0 0 k-math-div( $kendo-pdf-viewer-page-spacing, 2 ) $kendo-pdf-viewer-page-border !default; | |||
|
|
|||
| $kendo-pdf-viewer-search-panel-padding-x: $kendo-toolbar-md-padding-x !default; | |||
| $kendo-pdf-viewer-search-panel-padding-y: k-map-get( $kendo-spacing, 3 ) !default; | |||
| $kendo-pdf-viewer-search-panel-spacing: $kendo-toolbar-md-spacing !default; | |||
| $kendo-pdf-viewer-search-panel-border-width: 1px !default; | |||
There was a problem hiding this comment.
Maybe we should separate these variables as in the other themes, otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related https://github.com/telerik/kendo-themes-private/issues/36