feat: Elevation #4659
Merged
feat: Elevation #4659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We have a new design for the color gradient drag handle, where we use the default shadow from our elevation system. So there is no need to customize the elevation color. |
inikolova
reviewed
Aug 29, 2023
inikolova
reviewed
Aug 29, 2023
|
LGTM |
kirchoni
commented
Aug 30, 2023
There was a problem hiding this comment.
I've identified a couple of deleted variables - there's probably more. This should not be done in a minor release such as this one.
For such cases, consider keeping the old variables, but re-assigning their values to some of the newly introduced APIs (such as elevation()).
JoomFX
reviewed
Aug 30, 2023
imasyuko
reviewed
Aug 30, 2023
kirchoni
force-pushed
the
elevation
branch
2 times, most recently
from
8a75748 to
487a857
Compare
imasyuko
approved these changes
Aug 31, 2023
kirchoni
force-pushed
the
elevation
branch
2 times, most recently
from
e22d25e to
1e4b53e
Compare
JoomFX
approved these changes
Sep 12, 2023
inikolova
approved these changes
Sep 13, 2023
kirchoni
force-pushed
the
elevation
branch
2 times, most recently
from
1ae7903 to
766cfa1
Compare
Juveniel
requested changes
Sep 13, 2023
kirchoni
force-pushed
the
elevation
branch
6 times, most recently
from
d78fac3 to
713db3f
Compare
Juveniel
reviewed
Sep 19, 2023
kirchoni
force-pushed
the
elevation
branch
3 times, most recently
from
5162a3d to
1f62b09
Compare
chore(default): implement core elevation system
chore(fluent): implement core elevation system chore(utils): implement core elevation system chore(core): use k- meta functions chore: normalize comments
chore(fluent): explicit forward to utils feat: implemnet elevation system chore(bootstrap): implement global elevation system chore(classic): implement global elevation system chore: regen docs chore: update core elevation system variable chore(fluent): use css variables of global shadow system chore: regen docs chore(core): improve visibility of core elevations chore: regen docs chore: regen docs chore(material): implement global elevation system chore: regen docs chore: review elevation steps in widgets chore: unify elevations with design guidelines chore(colorgradient): update draghandle styles chore: regen docs chore: clear temporary comments chore(core): simplify the elevation function chore(default): fix contrast of the colorgradient draghandle chore: support multi-shadow filter chore(bootstrap): floating point precision shadows chore(default): do not rename variables based on implementation chore(bootstrap): deprecate box-shadow variables chore(fluent): deprecate box-shadow variables chore(default): deprecate box-shadow variables chore(material): deprecate box-shadow variables chore(classic): deprecate box-shadow variables docs: generate API chore(bootstrap): remove obsolete comments chore(core): enable css vars chore: refactor elevation styles loading chore(fluent): enable elevation customization chore(core): merge elevation map chore(core): prefix elevation getter function chore(default): org-chart focus elevations docs: generate API
Juveniel
approved these changes
Sep 21, 2023
Juveniel
added
T: Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of https://github.com/telerik/kendo-themes/pull/4653/files
Target: https://github.com/telerik/kendo-themes-private/issues/102
Introduces common module for elevation (box-shadows which are used as a focus indicator are not part of this PR).
Utils classNames are defined as
k-elevation-*(ranging from 1 to 9) and are contextual based on the currently loaded theme.TODO: replace remaining standalone
box-shadowstyles (used for elevation only) in the following themes;Also: