Toolbar overflow #5509
Open
Toolbar overflow #5509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages Report
|
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive support for scrollable toolbar layouts with badge containers by introducing new tests and updating styling.
- Introduces new HTML and TSX tests for scrollable toolbar across small, medium, and large sizes.
- Removes outdated badge-in-scrollable tests and related imports from the main toolbar tests.
- Updates Fluent and Core SCSS to apply consistent padding and margin for
.k-toolbar-items-scroll.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/toolbar/toolbar-scrollable-components.html | New static HTML tests covering scrollable toolbar scenarios. |
| tests/toolbar/toolbar-components.html | Removed legacy scrollable badge tests. |
| packages/html/src/toolbar/tests/toolbar-scrollable-components.tsx | Added dynamic TSX tests for scrollable toolbar across sizes. |
| packages/html/src/toolbar/tests/toolbar-components.tsx | Removed ToolbarScrollable import and associated test section. |
| packages/fluent/scss/toolbar/_layout.scss | Added size-specific padding/margin rules for .k-toolbar-items-scroll. |
| packages/core/scss/components/toolbar/_layout.scss | Mirror updates: padding/margin adjustments for scrollable items. |
epetrow
requested changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5507
Related to: #5441