Skip to content

Grid stack layout fixes #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Grid stack layout fixes #5511

wants to merge 10 commits into from

Conversation

TeyaVes
Copy link
Contributor

@TeyaVes TeyaVes commented Jul 9, 2025

Grid stack layout fixes and improvements reported by the engineering teams.

Issues addressed:

  • Improved position of the dirty cell
  • Added focus and selected state to the stacked cell
  • Removed styles for k-grouping-aggregates-item-text and k-grouping-aggregates-item-value (added in the previous commit) because the grouping-aggregates use templates
  • Added min-height to the stacked cell content to reserve space for targeting the content if it's empty (needed for editing)

Copy link

github-actions bot commented Jul 9, 2025

Packages Report

core default classic bootstrap material fluent utils
Size 29.15 KB (0.0%) 782.41 KB (0.1%🔼) 782.43 KB (0.1%🔼) 794.49 KB (0.1%🔼) 927.99 KB (0.1%🔼) 1152.86 KB (0.0%🔼) 625.19 KB (0.0%)
Gzip Size 4.85 KB (0.0%) 101.11 KB (0.1%🔼) 101.39 KB (0.1%🔼) 103.60 KB (0.2%🔼) 114.67 KB (0.2%🔼) 136.60 KB (0.1%🔼) 52.16 KB (0.0%)
Compile Time 2 s (0.0%) 4 s (0.0%) 3 s (0.0%) 4 s (0.0%) 4 s (0.0%) 5 s (0.0%) 5 s (0.0%)

@TeyaVes TeyaVes self-assigned this Jul 10, 2025
@TeyaVes TeyaVes force-pushed the grid-stack-layout-fixes branch 2 times, most recently from 74f8f82 to 6cdce7b Compare July 10, 2025 09:46
@TeyaVes TeyaVes marked this pull request as ready for review July 10, 2025 09:54
@TeyaVes TeyaVes requested a review from a team as a code owner July 10, 2025 09:54
@TeyaVes TeyaVes requested a review from Copilot July 10, 2025 09:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Grid stack layout by introducing cell state examples, adding a “dirty” state, refining focus and selection styling, and updating test fixtures and SCSS variables/themes to support these states.

  • Added a new “Stack Layout Cell States” example with toolbar and large pager in both HTML and React tests
  • Introduced dirty prop support in GridStackCell, updated markup/tests, and reserved min-height for empty cells
  • Extended SCSS across Material, Fluent, Default, Core, Classic, and Bootstrap themes to include $kendo‐grid‐stack‐focus‐outline and focused/selected cell styles

Reviewed Changes

Copilot reviewed 17 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/grid/grid-stack-layout.html Added “Cell States” section, updated section headings, toolbar buttons, and pager size classes
packages/html/src/grid/tests/grid-stack-layout.tsx Updated test component to render focus, selected, and dirty states; simplified example order
packages/html/src/grid/tests/grid-stack-layout-columns.tsx Enabled dirty prop in column‐based tests
packages/html/src/grid/grid-stack-cell.spec.tsx Extended GridStackCell props/states to include dirty, updated classNames logic
SCSS files in packages/*/scss/grid/ (_variables, _theme, _layout) Added $kendo-grid-stack-focus-outline, focus/selected cell rules, and min-height for empty content
Comments suppressed due to low confidence (3)

packages/core/scss/components/grid/_layout.scss:1125

  • [nitpick] Add a comment explaining that min-height is reserved for cells with empty content, so future maintainers understand the layout rationale.
    .k-grid-stack-content {

packages/default/scss/grid/_variables.scss:349

  • [nitpick] Different themes use varying opacity for $kendo-grid-stack-focus-outline. If this is intentional, document the rationale or unify the opacity levels for consistency.
$kendo-grid-stack-focus-outline: color-mix(in srgb, k-color(on-app-surface) 12%, transparent) !default;

packages/fluent/scss/grid/_theme.scss:480

  • The k-spacing function must be imported in this file for outline-offset to compile. If spacing utilities aren't already included, add @use "../../spacing/index.import.scss" as *; at the top.
            outline-offset: k-spacing(0.5);

@TeyaVes TeyaVes marked this pull request as draft July 15, 2025 07:32
@TeyaVes TeyaVes force-pushed the grid-stack-layout-fixes branch 2 times, most recently from 765c21f to 174c199 Compare July 16, 2025 08:14
@TeyaVes TeyaVes marked this pull request as ready for review July 16, 2025 08:30
@TeyaVes TeyaVes force-pushed the grid-stack-layout-fixes branch from bafa813 to 90cfaa1 Compare July 16, 2025 09:29
@TeyaVes TeyaVes force-pushed the grid-stack-layout-fixes branch from 90cfaa1 to 7dc3381 Compare July 16, 2025 09:34
@inikolova inikolova self-requested a review July 17, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants