-
Notifications
You must be signed in to change notification settings - Fork 70
Grid stack layout fixes #5511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Grid stack layout fixes #5511
Conversation
Packages Report
|
74f8f82
to
6cdce7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the Grid stack layout by introducing cell state examples, adding a “dirty” state, refining focus and selection styling, and updating test fixtures and SCSS variables/themes to support these states.
- Added a new “Stack Layout Cell States” example with toolbar and large pager in both HTML and React tests
- Introduced
dirty
prop support inGridStackCell
, updated markup/tests, and reserved min-height for empty cells - Extended SCSS across Material, Fluent, Default, Core, Classic, and Bootstrap themes to include
$kendo‐grid‐stack‐focus‐outline
and focused/selected cell styles
Reviewed Changes
Copilot reviewed 17 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tests/grid/grid-stack-layout.html | Added “Cell States” section, updated section headings, toolbar buttons, and pager size classes |
packages/html/src/grid/tests/grid-stack-layout.tsx | Updated test component to render focus , selected , and dirty states; simplified example order |
packages/html/src/grid/tests/grid-stack-layout-columns.tsx | Enabled dirty prop in column‐based tests |
packages/html/src/grid/grid-stack-cell.spec.tsx | Extended GridStackCell props/states to include dirty , updated classNames logic |
SCSS files in packages/*/scss/grid/ (_variables, _theme, _layout) | Added $kendo-grid-stack-focus-outline , focus/selected cell rules, and min-height for empty content |
Comments suppressed due to low confidence (3)
packages/core/scss/components/grid/_layout.scss:1125
- [nitpick] Add a comment explaining that
min-height
is reserved for cells with empty content, so future maintainers understand the layout rationale.
.k-grid-stack-content {
packages/default/scss/grid/_variables.scss:349
- [nitpick] Different themes use varying opacity for
$kendo-grid-stack-focus-outline
. If this is intentional, document the rationale or unify the opacity levels for consistency.
$kendo-grid-stack-focus-outline: color-mix(in srgb, k-color(on-app-surface) 12%, transparent) !default;
packages/fluent/scss/grid/_theme.scss:480
- The
k-spacing
function must be imported in this file foroutline-offset
to compile. If spacing utilities aren't already included, add@use "../../spacing/index.import.scss" as *;
at the top.
outline-offset: k-spacing(0.5);
…ggregates items styles
765c21f
to
174c199
Compare
bafa813
to
90cfaa1
Compare
90cfaa1
to
7dc3381
Compare
Grid stack layout fixes and improvements reported by the engineering teams.
Issues addressed:
k-grouping-aggregates-item-text
andk-grouping-aggregates-item-value
(added in the previous commit) because the grouping-aggregates use templates