feat: replace narray with numo-narray#120
Open
oleksii-leonov wants to merge 1 commit intotelus-agcg:developfrom
Open
feat: replace narray with numo-narray#120oleksii-leonov wants to merge 1 commit intotelus-agcg:developfrom
oleksii-leonov wants to merge 1 commit intotelus-agcg:developfrom
Conversation
Contributor
Author
|
Issue #55. |
turboladen
reviewed
Jan 30, 2026
| end | ||
| end | ||
|
|
||
| # DEPRECATED: Use Numo::NArray directly instead. |
Contributor
|
Just a note for any future 👀 that this contains API-breaking changes, so should cause a major version bump. |
turboladen
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing
narraywithnumo-narray.Some improvements/fixes:
narray,GDT_UInt32was mapped toNArray::INT, which could lead to overflow.narray,GDT_UInt16was mapped toNArray::INT, which is Ok, but wastes memory.numo-narrayhas more types available, so now mapping is a bit more precise:numo-narrayis not a drop-in replacement fornarray, some APIs are different.It's highly possible that it is a breaking change for some users. But keeping
narray, which is C code, unsupported for 10 years, is very shaky.