Skip to content

Fix docstring for workflow.defn's dynamic argument #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scorphus
Copy link

What was changed

This CL fix the docstring for the dynamic argument of the workflow.defn function, replacing one occurrence of activity by workflow to better reflect the usage of such attribute. I assume that was leftover of some copy'n'paste.

Why?

workflow.defn is used to decorate a workflow class, not an activity.

Checklist

  1. Closes ✅
    None

  2. How was this tested: ✅
    No tests necessary, I guess.

  1. Any docs updates needed? ✅
    All good here too.

Valeu pelo Temporal, turma! Ele faz miséria! <3

@scorphus scorphus requested a review from a team as a code owner March 17, 2025 14:50
@CLAassistant
Copy link

CLAassistant commented Mar 17, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants