Reduce dynamic config client log level to INFO to address noisy debug logging #8354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaptersix
changed the title
dnr
added a commit
that referenced
this pull request
Oct 7, 2025
## What changed? Remove logging when default dynamic config values are used. Also revert #8354 which was just to avoid these logs in tests. ## Why? These logs are not really useful, we expect almost all keys to usually be unset. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added functionality to override the dynamic config client log level to INFO for all services in the functional tests.
Why?
The dynamic config client introduced in #7052 logs "No such key in dynamic config, using default" at DEBUG level every time a dynamic config key is checked without an override. This creates extremely noisy logs during testing as it fires for many dynamic config checks, making it difficult to see relevant test output and debug information.
This approach:
How did you test it?