Add external payload size and count to Visibility Schema #9007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
requested changes
Jan 15, 2026
| @@ -0,0 +1,25 @@ | |||
| ALTER TABLE executions_visibility | |||
| ADD COLUMN TemporalExternalPayloadSizeBytes BIGINT | |||
| GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadSizeBytes"); | |||
Contributor
There was a problem hiding this comment.
Suggested change
| GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadSizeBytes"); | |
| GENERATED ALWAYS AS (search_attributes->"$.TemporalExternalPayloadSizeBytes"); |
|
|
||
| ALTER TABLE executions_visibility | ||
| ADD COLUMN TemporalExternalPayloadCount BIGINT | ||
| GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadCount"); |
Contributor
There was a problem hiding this comment.
Suggested change
| GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadCount"); | |
| GENERATED ALWAYS AS (search_attributes->"$.TemporalExternalPayloadCount"); |
Comment on lines
54
to
55
| TemporalExternalPayloadSizeBytes BIGINT GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadSizeBytes"), | ||
| TemporalExternalPayloadCount BIGINT GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadCount"), |
Contributor
There was a problem hiding this comment.
Suggested change
| TemporalExternalPayloadSizeBytes BIGINT GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadSizeBytes"), | |
| TemporalExternalPayloadCount BIGINT GENERATED ALWAYS AS (search_attributes->>"$.TemporalExternalPayloadCount"), | |
| TemporalExternalPayloadSizeBytes BIGINT GENERATED ALWAYS AS (search_attributes->"$.TemporalExternalPayloadSizeBytes"), | |
| TemporalExternalPayloadCount BIGINT GENERATED ALWAYS AS (search_attributes->"$.TemporalExternalPayloadCount"), |
simvlad
force-pushed
the
simvlad/add-external-payload-stats-to-visibility
branch
from
cc5e52f to
f1ba85c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added TemporalExternalPayloadSizeBytes and TemporalExternalPayloadCount to Visibility Schema as pre-defined search attribute.
Why?
We are planning to expose external payload size and count as the search attributes. They are pre-defined, rather than system, because they won't be set on every single workflow, but only ones which store large payloads externally (e.g. in S3).
How did you test it?
Potential risks
Incorrectly modified schema