Skip to content

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jan 14, 2026

What changed?

  • Some unit-tests for the change that went in here
  • Added unit-tests for the helpers, present in worker-deployment's util file, that are doing the hard work of checking if an error is retryable or not.

Why?

  • Bullet proofing our feature.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • None, more tests.

Note

Strengthens coverage of retryability helpers used by worker deployment.

  • Add tests for isRetryableUpdateError covering ErrWorkflowClosing, AbortedByServerErr, ResourceExhausted causes (CONCURRENT_LIMIT, BUSY_WORKFLOW), WorkflowNotReady, and MultiOperationExecution (including nil entries and mixed errors)
  • Add tests for isRetryableQueryError ensuring Internal is excluded, Unavailable and history consts errors are retryable, and MultiOperationExecution behavior matches expectations
  • Cleans up obsolete commented test; minor import additions for new cases

Written by Cursor Bugbot for commit 9dcdd83. This will update automatically on new commits. Configure here.

@Shivs11 Shivs11 requested review from a team as code owners January 14, 2026 14:46
@Shivs11 Shivs11 changed the title add unit-test for the function [worker-versioning]: unit-test for helpers deciding whether an error is retryable or not Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants