Skip to content

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jan 15, 2026

What changed?

  • We should be checking if a query is blackholed only by checking the appropriate conditions on the root partition.
  • Moreover, added the testhook bug about read partitions over here which @dnr spotted!

Why?

  • Correctness.
  • Moreover, the test TestVersioning3FunctionalSuiteV0/TestPinnedQuery_RollbackDrainedVersion was failing after the testhook bug fix. The root partition check also fixed it!

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • None.

Note

Ensures query blackhole detection only runs on the root partition to avoid false "no pollers" errors across partitions.

  • Update checkQueryBlackholed to early-return on non-root partitions and add clarifying comments
  • Fix load balancer testhook to use MatchingLBForceReadPartition when forcing read partition selection

Written by Cursor Bugbot for commit b60509c. This will update automatically on new commits. Configure here.

@Shivs11 Shivs11 requested review from a team as code owners January 15, 2026 19:13
@Shivs11 Shivs11 enabled auto-merge (squash) January 15, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants