Add health check handler for worker service #9055
Open
+76
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Jan 16, 2026
dnr
reviewed
Jan 17, 2026
yiminc
force-pushed
the
add-worker-health-check
branch
from
3f43e72 to
c13a110
Compare
Add gRPC health check support to the worker service on port 7239. The health check follows the same pattern as other Temporal services, reporting SERVING status when started and NOT_SERVING when stopped. Includes an integration test that verifies health check is properly wired up through the NewService() lifecycle. Co-Authored-By: Claude Opus 4.5 <[email protected]>
yiminc
force-pushed
the
add-worker-health-check
branch
from
c13a110 to
ef5ab04
Compare
Remove the mock-heavy unit test TestNewServiceHealthCheck and replace it with a functional test that makes real gRPC health check calls against a running worker service. This eliminates the maintenance burden of updating mocks when new dependencies are added to the worker service. Changes: - Add WorkerGRPCAddress() method to expose worker service address - Add TestWorkerServiceHealthCheck functional test - Remove service/worker/service_test.go Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
server,grpcListener,healthServerfields to worker Service structStart()withSERVINGstatusNOT_SERVINGstatus and gracefully stop inStop()ServerProviderin fx.go for dependency injectionTest plan
TestHealthCheckpasses$ grpcurl -plaintext -d '{"service": "temporal.api.workflowservice.v1.WorkerService"}' localhost:7239 grpc.health.v1.Health/Check
{
"status": "SERVING"
}
Fixes #2582
🤖 Generated with Claude Code