Skip to content

Conversation

@dandavison
Copy link
Contributor

@dandavison dandavison commented Jan 19, 2026

What changed?

Clarify an error message.

Why?

The error message wasn't written clearly.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests

I have seen the new message in local testing:

{
  "level": "warn",
  "ts": "2026-01-19T14:23:09.763-0500",
  "msg": "Workflow task attempt 20 exceeds critical threshold (10)",
  "shard-id": 1,
  "address": "127.0.0.1:7234",
  "wf-namespace": "default",
  "wf-id": "test-stats-minimal:019bd761-bf89-7a12-b00b-b5f6386e7458-config-driven-minimalstatstest-1",
  "wf-run-id": "55242767-89b6-4e33-97ab-93eff948149f",
  "attempt": 20,
  "logging-call-at": "/Users/dan/src/temporal-all/repos/temporal/service/history/workflow/workflow_task_state_machine.go:1345"
}

Potential risks

Could panic in WFT processing if the code has a bug.


Note

Improves the warn log emitted when workflow task attempts reach the critical threshold.

  • In workflow_task_state_machine.go, updates emitWorkflowTaskAttemptStats to compute threshold once and log a formatted message: Workflow task attempt <attempt> exceeds critical threshold (<threshold>)
  • Adds fmt import to support the new formatted log message

Written by Cursor Bugbot for commit 401dbd3. This will update automatically on new commits. Configure here.

@dandavison dandavison requested review from a team as code owners January 19, 2026 20:52
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants