fix: /blocks gap when pausing then resuming #220
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deploying o-az/fix-blocks-gap with ⚡ Cloudflare Pages
|
bpierre
approved these changes
Dec 9, 2025
|
|
||
| // If we have existing blocks, check for continuity | ||
| const prevLatest = prev[0]?.number | ||
| if (prevLatest != null && latestBlock.number != null) { |
Member
There was a problem hiding this comment.
should we stick to strict equals? or just prevLatest && latestBlock.number
| // Re-initialize liveBlocks when empty and fetchedBlocks is ready | ||
| // Don't fall back to queryData.blocks here - it may be stale after a gap reset. | ||
| // The blocks memo handles the temporary display while fetchedBlocks loads. | ||
| React.useEffect(() => { |
Member
There was a problem hiding this comment.
I think we could skip the useEffect here since we check for liveBlocks.length === 0 and fetchedBlocks.length > 0, guaranteeing that the next render will fill liveBlocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219
Before:
new blocks were prepended to stale data, creating gaps:
[150, 100, 99, ...]After:
gap detection clears stale data and triggers a refetch:
[150, 149, 148, ...]