Script Overhaul

[emabrey]

As referenced in https://github.com/tenacityteam/tenacity/pull/407 we needed to overhaul our contributor scripts and cleanup their directory layout.

Checklist

• I have signed off my commits using -s or Signed-off-by* (See: Contributing § DCO)
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code*
• I made sure the title of the PR reflects the core meaning of the issue you are solving*
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"*

* indicates required

[nbsp]

I think it might make more sense to separate the user scripts entirely, and put them all in contrib/{images/locale/etc.}.

[emabrey]

Doing that makes having a default location for where the scripts are modifying things more awkward. Right now the scripts are immediately next to the directories they modify.

[fossdd]

See lines 3-8.

[Semisol]

I tried this syntax on a few of my systems and it sometimes does not work.
Also, collapsed it to $DIRNAME in my patch

Suggested change

	input_dirs[0]="${BASH_SOURCE[0]}/../../images/EditButtons"
	input_dirs[1]="${BASH_SOURCE[0]}/../../images/TranscriptionImages"
	input_dirs[2]="${BASH_SOURCE[0]}/../../images/ControlButtons"
	DIRNAME=$(dirname "${BASH_SOURCE[0]}")
	input_dirs[0]="$DIRNAME/../../images/EditButtons"
	input_dirs[1]="$DIRNAME/../../images/TranscriptionImages"
	input_dirs[2]="$DIRNAME/../../images/ControlButtons"

[Semisol]

I tried this syntax on a few of my systems and it sometimes does not work.
Also, collapsed it to $DIRNAME in my patch

Suggested change

	input_dirs[0]="${BASH_SOURCE[0]}/../../images/EditButtons"
	input_dirs[1]="${BASH_SOURCE[0]}/../../images/TranscriptionImages"
	input_dirs[2]="${BASH_SOURCE[0]}/../../images/ControlButtons"
	DIRNAME=$(dirname "${BASH_SOURCE[0]}")
	input_dirs[0]="$DIRNAME/../../images/EditButtons"
	input_dirs[1]="$DIRNAME/../../images/TranscriptionImages"
	input_dirs[2]="$DIRNAME/../../images/ControlButtons"

[emabrey]

Yeah BASH_SOURCE isn't perfect. It doesn't take symlinks into account for example. https://stackoverflow.com/questions/421772/how-can-a-bash-script-know-the-directory-it-is-installed-in-when-it-is-sourced-w

[Semisol]

dirname is sort of the best thing we can get that works with most systems I assume?

[emabrey]

dirname is sort of the best thing we can get that works with most systems I assume?

It should be sufficient. There are ways to support symlinks but I don't think it's needed.

[nbsp]

Could we change the scripts to use /bin/sh instead of /bin/bash? Not every system has bash installed on it.

This might not be as simple as changing the shebang; we'll need to check for bashisms throughout the scripts and remove them.

[Semisol]

we'll need to check for bashisms throughout the scripts and remove them

BASH_SOURCE, and ${BLABLA[idx]} does not work on sh I believe

[emabrey]

Could we change the scripts to use /bin/sh instead of /bin/bash? Not every system has bash installed on it.

This might not be as simple as changing the shebang; we'll need to check for bashisms throughout the scripts and remove them.

Yeah I can do that.

[nbsp]

@emabrey mind if I take a crack at converting the files to /bin/sh?

[n0toose]

Considering that she is currently absent from the project, I see no reason for that to not happen. It's an already agreed approach, we better do something than nothing. @solfisher

[Be-ing]

If you want to make the scripts more portable, sure, why not?

[nbsp]

removing bashisms was simple, but I might've messed up the rebase -- if someone could please check to see I've not added/removed anything important