Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more elements in qir for cirq #175

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add support for more elements in qir for cirq #175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f33c0f
Add support for more elements in qir for cirq
JettChenT Aug 6, 2023
313b202
black format
JettChenT Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tensorcircuit/translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,16 @@ def _circuit_diagram_info_(self) -> List[str]:
ci_name = gate_info["name"]
cgate = CustomizedCirqGate(gatem, ci_name, len(index))
cmd.append(cgate.on(*index))
elif gate_name == "measure":
cmd.append(cirq.MeasurementGate(key=gate_info["name"]).on(*index))
elif gate_name == "reset":
cmd.append(cirq.ResetChannel().on(*index))
elif gate_name in ["ox", "oy", "oz"]:
cmd.append(getattr(cirq, gate_name[1:])().controlled().on(*index))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no value specified, controlled is for cx cy cz gates?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Theoretically that would be the case, as Gate.controlled() turns a gate (x,y,z in this case) into a controlled gate according to cirq's documentation.
Though I am still having some trouble trying to set up the development environment on my mac M2 machine, and haven't been able to test the gates yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for m2, I guess this may help https://tensorcircuit.readthedocs.io/en/latest/contribs/development_Mac.html

elif gate_name in ["orx", "ory", "orz"]:
cmd.append(getattr(cirq, gate_name[1:])(_get_float(parameters, "theta")).controlled().on(*index))
elif gate_name == "phase":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gate has parameters

cmd.append(cirq.PhaseGate)
else:
# Add Customized Gate if there is no match
gatem = np.reshape(
Expand Down
Loading