This repository was archived by the owner on Mar 11, 2021. It is now read-only.
Show numbers on moves branched from main line #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 18, 2019 15:44
…bels. Position::addChild() will now add annotations to non-mainline children.
|
fixes #849 |
|
oh hmm, this actually won't work really well if there's a ko in the variation. Maybe don't review it just yet XD |
|
Ok, i added some duplication check to the annotation code in position.ts. The annotation layer should probably be keeping a map keyed by position instead of a flat array, but maybe that's for next time. Ready for review here |
brilee
reviewed
Jul 23, 2019
tommadams
reviewed
Jul 23, 2019
tommadams
reviewed
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this seems to work ok. It's a little weird -- the annotation layer always copies in its annotations from the underlying Position object, so i ended up making these annotations at the time the new Positions are created and just toggling their visibility. It's not a great solution but it seems to work ok. Happy to think about refactors that would make this make more sense.
Switching the last-move indicator to unicode seems to work and also to be aligned correctly :)
The fix on board.ts seems like a new one because of type information added to the context object? I don't think i changed the original behavior but maybe i did?