Skip to content

Add a workflow to build wheels and (only on release) publish to PyPI #6892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Aug 6, 2024

This PR adds a workflow which automatically builds an sdist and a wheel when a pull request is made. If a release is made, the wheels are built and then automatically published to PyPI. Unfortunately I cannot use cibuildwheel to target many different architectures at this time because the build system is quite unusual, and will need some additional work to make it compatible with current best practices.

@pradeepkuppla We'll need to enable trusted publishing on the tfx project page to get this to work. Instructions are here, or I can guide you through this - it's straightforward to do, and should take only a few minutes.

In testing the build locally, I've also added a few build artifacts to .gitignore. I tested this workflow to the extent that I could, but I will need to get trusted publishing set up on PyPI for this project to be sure about it.

@peytondmurray peytondmurray force-pushed the 5-build-workflow branch 2 times, most recently from 21f9625 to 6701de6 Compare August 6, 2024 23:49
@peytondmurray peytondmurray marked this pull request as ready for review August 6, 2024 23:55
@peytondmurray peytondmurray changed the title [WIP] Add a workflow to build wheels and (only on release) publish to PyPI Add a workflow to build wheels and (only on release) publish to PyPI Aug 6, 2024
@gbaned gbaned requested a review from roseayeon August 12, 2024 06:28
@gbaned gbaned self-assigned this Aug 12, 2024
@peytondmurray
Copy link
Contributor Author

peytondmurray commented Aug 14, 2024

Looks like there are some breaking changes between actions/upload-artifact v3 and v4 which disallow modifying artifacts. Should be fixed. @roseayeon Can you re-trigger workflows?

@roseayeon roseayeon merged commit 55a076c into tensorflow:master Aug 16, 2024
3 checks passed
@peytondmurray peytondmurray deleted the 5-build-workflow branch August 16, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants