Skip to content

Add basic pyproject.toml #6907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 2, 2024
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Aug 21, 2024

The setup.py and package dependencies are quite complicated. It would be non-trivial to replace all with pyproject.toml in one PR. This is one of many PRs to surgically remove setup.py and use pyproject.toml.

Since pyproject.toml is a static configuration file in contrast to dynamic setup.py, we're trying to use both at the moment until we fully replace everything in setup.py.

We're currently building three packages in this project:

  • tfx
  • ml-pipelines-sdk
  • tfx-dev (for development, which is a union of the above two)

I have created explicit pyproject.toml files for the three types of builds we're doing. There might be some duplication in these files, but now is not the time to extract them, until we fully replace setup.py and old build machinery (including installation of specific components via optional dependencies instead of environment variables).

@keerthanakadiri keerthanakadiri self-assigned this Aug 22, 2024
@peytondmurray peytondmurray self-requested a review August 26, 2024 05:20
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a double check on the pytest-runner build time dependency.

@aktech aktech force-pushed the introduce-pyproject.toml branch from 8b698bf to 9631a43 Compare August 28, 2024 09:39
@aktech aktech marked this pull request as ready for review August 28, 2024 10:34
@aktech aktech merged commit dcc7f49 into tensorflow:master Sep 2, 2024
7 checks passed
@aktech aktech deleted the introduce-pyproject.toml branch September 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants