-
Notifications
You must be signed in to change notification settings - Fork 723
Add basic pyproject.toml
#6907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add basic pyproject.toml
#6907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a double check on the pytest-runner
build time dependency.
8b698bf
to
9631a43
Compare
peytondmurray
approved these changes
Aug 28, 2024
AnuarTB
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup.py
and package dependencies are quite complicated. It would be non-trivial to replace all withpyproject.toml
in one PR. This is one of many PRs to surgically remove setup.py and usepyproject.toml
.Since
pyproject.toml
is a static configuration file in contrast to dynamic setup.py, we're trying to use both at the moment until we fully replace everything in setup.py.We're currently building three packages in this project:
I have created explicit
pyproject.toml
files for the three types of builds we're doing. There might be some duplication in these files, but now is not the time to extract them, until we fully replacesetup.py
and old build machinery (including installation of specific components via optional dependencies instead of environment variables).