Project Web Mercator Tiles to Sphere with ShaderMaterial #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tentone
approved these changes
Jun 27, 2024
Owner
tentone
left a comment
tentone
left a comment
There was a problem hiding this comment.
Hello
Check documentation for auxiliary methods please, other than that code seems alright.
Comment on lines
149
to
156
| public static getTileSize(zoom: number): number | ||
| { | ||
| const maxExtent = UnitsUtils.MERCATOR_MAX_EXTENT; | ||
| const numTiles = Math.pow(2, zoom); | ||
| return 2 * maxExtent / numTiles; | ||
| } | ||
|
|
||
| public static tileBounds(zoom: number, x: number, y: number): number[] |
Owner
There was a problem hiding this comment.
Please add docs for these parameters.
Author
|
Okay, I added some documentation for those methods, I reverted the build folder to before my changes, and I fixed some weird indentation on the shader code. |
|
i have modify code as yours but there still some misalignment expecially in high level |
Author
|
I'm not sure if this PR is the right place to discuss, but the problem you're having is because the tile bounds expected by the shader code don't match the tile bounds used for the tile's geometry, specifically in the Y/latitutde direction. I recommend using identical calculations for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #74, where I also wrote some comments about my work as I went.
The changes are primarily to MapSphereNode, specifically swapping the material for a ShaderMaterial that calculates the color of a given position by looking up the corresponding pixel on the web mercator tile image. In addition, we change the size of the tiles so that their position properly matches the coordinates they are supposed to show. This method, while not identical, was inspired by a very similar approach used by CesiumJS.
Added the
applyTexturefunction for MapNode base class so that MapSphereNode could override it load the texture into the ShaderMaterial.Also added some utility functions to UnitsUnitls.
I wasn't sure whether to update the build/ folder or not, I can remove those changes from the PR if necessary.
Before:
After:
