Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main/just): fix recipe shebangs #22293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomJo2000
Copy link
Member

I don't know enough Rust to even begin to reason about why this patch doesn't work.

If someone else could look into it that would be appreciated.
This is intended to solve the shebang incompatibility I found as part of #22291.
It should be as simple as prepending the @TERMUX_PREFIX@ path to the interpreter.
But I have a headache and apparently negative knowledge of Rust.

@TomJo2000 TomJo2000 marked this pull request as draft November 16, 2024 22:21
@TomJo2000 TomJo2000 force-pushed the just-runtime-dir branch 4 times, most recently from 0889d3a to 1986443 Compare November 17, 2024 14:07
@TomJo2000 TomJo2000 marked this pull request as ready for review November 17, 2024 14:08
@TomJo2000
Copy link
Member Author

This doesn't seem to quite fix the XDG_RUNTIME_DIR problem yet.
But the shebang fix seems to be working already.

bug:
    #!/usr/bin/env sh
    echo "hello world"
XDG_RUNTIME_DIR="$PREFIX/var/run/user"
just bug
# hello world

@TomJo2000
Copy link
Member Author

TomJo2000 commented Nov 17, 2024

Nvm it works, my dotfiles were broken.
Just the shebangs that needed fixing.

Co-authored-by: kaike95 <[email protected]>
Co-authored-by: Ted Stein <[email protected]>
@TomJo2000
Copy link
Member Author

Already verified it on-device just waiting for the CI.

@TomJo2000
Copy link
Member Author

TomJo2000 commented Nov 17, 2024

It'd be appreciated if someone could double check this to make sure I didn't make any obvious mistake.

Either @flipee as the maintainer,
or @truboxl or @licy183 as frequent contributors to rust packages would be my choices off the top of my head.

Anyone else is of course welcome to leave a review or comment.

The source location for the patch is at
https://github.com/casey/just/blob/1.36.0/src/recipe.rs#L358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant