-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
scripts(toolchain): Update to NDK r28b #24866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Have published a prebuilt builder image at https://hub.docker.com/repository/docker/fredrikfornwall/package-builder-r28b-v1, which can be used to save time as: CONTAINER_NAME=ndk28-builder TERMUX_BUILDER_IMAGE_NAME=fredrikfornwall/package-builder-r28b-v1 ./scripts/run-docker.sh |
We've only been updating to the LTS NDKs in recent years. |
Ah right, r25, r26 and r27 were three consecutive LTS releases. I wonder if it makes sense to continuously update to NDK stable releases without awaiting LTS ones, to more continuously adapt to toolchain changes as soon as they are out? |
Honestly, their release process is a mess at this point, is "stable" still considered a rolling release? Who knows. I definitely think it makes sense to adapt to the stable releases in a branch, but whether we should switch the whole repo over now is an open question. Maybe Henrik, @truboxl, @licy183, and other contributors have input... |
I'd suggest that we wait for r28c. Regardless of r28c being LTS or not, I guess we should go ahead with it |
I'm afraid NDK r28* will not be the LTS release... See https://github.com/android/ndk/wiki |
Yes, we know it won't be: Fredrik is proposing that we switch to it anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in current shape. Also managed to build nodejs and nodejs-lts with little patchwork, so not bad, but I already had seen it coming. We might face build errors with packages that are using older C standards, as it seems like LLONG_MAX
and other macros are now only enabled for newer C standards (-std=c11
and later)
It's time to start looking at updating to NDK r28!
Haven't tested much, but a lot of basic packages build.
Fixes #21628