Conversation
33c7c86 to
40ce2b2
Compare
|
Hi @kleo thank you, I was wondering, could you explain a little what the difference is between this version and this other, more basic version? : TERMUX_PKG_HOMEPAGE=https://github.com/aandrew-me/tgpt
TERMUX_PKG_DESCRIPTION="AI Chatbots in terminal without needing API keys"
TERMUX_PKG_LICENSE="GPL-3.0"
TERMUX_PKG_MAINTAINER="@termux"
TERMUX_PKG_VERSION="2.10.0"
TERMUX_PKG_SRCURL=https://github.com/aandrew-me/tgpt/archive/refs/tags/v${TERMUX_PKG_VERSION}.tar.gz
TERMUX_PKG_SHA256=0e312176908d581eeb7f0df8fcd0524a4aa4702029d50f553f0f75d6c15bc0d9
TERMUX_PKG_AUTO_UPDATE=true
TERMUX_PKG_BUILD_IN_SRC=true
termux_step_pre_configure() {
termux_setup_golang
}
termux_step_make() {
go build
}
termux_step_make_install() {
install -Dm700 tgpt "$TERMUX_PREFIX"/bin/tgpt
}I was wondering because, in this case, I think the extra-specific build arguments might not be necessary. For example, compare the Arch Linux package you copied with this AUR https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=tgpt-git |
|
Also I can confirm it's working. It's a little bit scary to let it do something on my phone but this is probably enough. |
|
I don't know about the flags and options used from the PKGBUILD @twaik from the Arch Linux package. Earlier I was looking into tgpt's https://github.com/aandrew-me/tgpt/blob/main/build.sh build options if I could use it here. But I'll be going for the tgpt-git AUR suggestion instead. Thanks @robertkirkman! |
|
The next thing to do is, the 5 commits should be squashed (combined into 1 single commit named "addpkg(main/tgpt): 2.10.0"). after that I think it will be ready. |
TomJo2000
left a comment
There was a problem hiding this comment.
Build script seems fine.
As mentioned please squash the commits and use a commit message that follows the commit message format as described in CONTRIBUTING.md
e.g addpkg(main/tgpt): 2.1.0
I will leave instructions for squashing your commits below.
(This is a pre-written, saved reply.)
Please make sure to keep your commits squashed by the way.
For adding to a single commit you can use git commit --amend.
Since you already have multiple commits on your branch though,
you'll need to squash those with git rebase -i HEAD~<n> first.
(Where <n> is the number of commits you want to modify.
Please make sure to only modify your commits.)
https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits
Since squashing or amending commits changes the git history you will need to force push any such changes.
e.g. git push --force,
or preferably git push --force-with-lease --force-if-includes
to make sure you aren't clobbering any refs you haven't fetched locally yet.
|
Hi sorry for the delay I'm just now getting back to this. |
|
Thank you for your contribution 👍 |
Why is it worth to add this package?
Accessible AI chatbot on terminal without API keys.
Home page URL
https://github.com/aandrew-me/tgpt
Source code URL
https://github.com/aandrew-me/tgpt
Packaging policy acknowledgement
Additional information
Just an attempt to add this package. I have read #17614. I'm not sure if it still violates the Termux Packaging Policy.
Build steps on build.sh are copied from the Arch Linux tgpt package PKGBUILD.