-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix(main/coreutils): explicitly depend on openssl
#25230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coreutils has been built as multi-call binary for the entire existence of Termux. In my opinion, 2.3 MB -> 7.3 MB is a big enough size multiplication (more than 2 times bigger) that it might not be worth increasing the package size of a package on every single Termux installation so much, just to better support a very old version of the app. While versioned dependencies are normally discouraged in Termux for lower-importance programs, there is a precedent for making an exception to add versioned dependencies to some critically-important core packages, in order to make sure that upgrades on older Termux Apps are possible. termux-packages/packages/libcurl/build.sh Line 10 in c8e204d
Maybe in this case, the tradeoff of having a versioned dependency is more favorable than the tradeoff of disabling the multi-call binary? |
Remind me why you change the maintainer field in the first place? |
True, it's a 200+% size increase in relative terms.
I absolutely agree, Having a versioned dependency on
I am anecdotally aware of at least one user specifically depending on the |
I have been set as the maintainer for the There were no objections to this at the time, I am happy to change it back to I don't believe I should be required to have an encyclopedic knowledge of all packaging decisions made about a package years before joining the project, to put myself down as a point of contact regarding that package. |
As I previously said, you can use CODEOWNERS for point of contact, multiple people can be set. Better way than changing maintainer field when multiple ternux devs maintain the package. Feel free to set it to yourself for packages you exclusively maintain. |
f7bb5cb
to
7188a52
Compare
- And set `--with-packager` value
7188a52
to
4108847
Compare
openssl
openssl
openssl
This PR changes our
coreutils
package to be built as separate binaries.The main motivation is this post on the subreddit.
https://www.reddit.com/r/termux/comments/1loqx08/mysterious_errors_encountered_while_upgrading/
Since the symlinked multi-call

coreutils
binary we currently ship for the package needs to depend on all of the dependencies for all component utilities.Whereas the split independent binaries only need to link against what they need.
What we need to do in any case is explicitly depend on
openssl
forlibcrypto.so.3
,which is needed by the
cksum
,md5sum
,sha{1,224,256,384,512}sum
utilities.It seems the option of using
libcrypto
for those was introduced in 8.22 (2013) as a performance enhancement.https://cgit.git.savannah.gnu.org/cgit/coreutils.git/tree/NEWS?h=v9.7#n2134
Though I am unsure if the
coreutils
package has been implicitly depending on it since the start of the Termux project.