enhance(scripts/lint-packages): account for package resurrections #26980
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJo2000
force-pushed
the
linter-handle-package-resurrection
branch
from
45f9f9b to
eb8176d
Compare
|
|
||
| # Did this package get "resurrected" from disabled-packages? | ||
| if [[ "$version_old" == '0-0' ]]; then | ||
| case "$(git diff --name-status --word-diff=porcelain "${base_commit}" -- "disabled-packages/${package_name}/build.sh" 2> /dev/null)" in |
There was a problem hiding this comment.
do you think these other cases also need to be handled, or can be ignored?
- package hypothetically moved from x11-packages to packages or some other combination
- deleted package restored that was hypothetically completely deleted instead of being moved to disabled-packages
i think that i have seen both of those situations happen before but i'm not sure if i really have.
There was a problem hiding this comment.
Had not considered those two.
The "fully deleted from the codebase" case seems reasonable to answer with, if it's gone it's gone and is thus no longer the linter's concern, although that would still face the same issue as described for the disabled-packages/ resurrection case described above.
Moving between package channels should probably be handled.
I think I have some ideas for how we could check this, but I'll need to test how reliable git diff --follow is for detecting these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the previously unhandled edgecase of a package being restored from
disabled-packages/with preexisting revisions.Originally spotted in: #26973 (comment)
The revision should not be reset in this edgecase as that could lead to situations where the freshly "resurrected" package is considered to be a lower version than the previously released revisions prior to the package's retirement.
CC: @robertkirkman @sabamdarif