Skip to content

Conversation

@ilyas-ozt
Copy link

No description provided.

@TomJo2000
Copy link
Member

TomJo2000 commented Oct 28, 2025

We really gotta talk about using a rebase workflow for your PRs, this is what attempt number 4 at this now?
You could have just made your changes, committed them with git commit --amend, and force pushed the changes with git push --force-with-lease --force-if-includes.
Opening a new PR is not necessary to make changes to it.

Making a separate development branch for your PRs is also generally helpful, but that boat has sailed for this PR so I'll just mention it as a general suggestion.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems close to actually being a merge-able build script for vlang.

If you need help with the workflow we can help you out with that, but if you're just gonna keep closing the old PR when you hit a problem and opening a new one then at some point me or @robertkirkman are probably just going to open a PR ourselves.

Opening multiple PRs isn't inherently an issue, but it makes reviewing and iterating on a build script much harder than it needs to be.

TERMUX_PKG_VERSION=0.4.12
TERMUX_PKG_SRCURL=https://github.com/vlang/v/archive/refs/tags/${TERMUX_PKG_VERSION}.tar.gz
TERMUX_PKG_SHA256=65e3579df61ae0a7314aa5f0c7eb3b0b9b45170a0275e392e9c168be23046e89
TERMUX_PKG_DEPENDS="build-essential, clang, make, libgc-dev, libexecinfo-dev, libatomic1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These depends don't make any sense and don't match dependencies for any other package of vlang.
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vlang-bin#n16
https://build.opensuse.org/projects/openSUSE:Factory/packages/vlang/files/vlang.spec
https://github.com/Homebrew/homebrew-core/blob/6c4e6736161b14b1345bc48990f8e56d4039fe42/Formula/v/vlang.rb#L23-L27

  • libgc seems to be correct, but we do not provide separate *-dev packages for headers, that's a Debian-ism.
  • build-essential, clang and make are provided as base components of the build environment.
  • I have no idea where you got libexecinfo or libatomic1 as dependencies from.

Copy link
Member

@TomJo2000 TomJo2000 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even notice this until I looked at the CI checks, this file is not in the correct location.
It should be at packages/vlang/build.sh.

At which the CI is instantly going to throw a failure due to the non-existent *-dev, libatomic1 and libexecinfo dependencies.

@robertkirkman
Copy link
Member

This PR seems close to actually being a merge-able build script for vlang.

Unfortunately, not quite yet - if you look closely, you can see that this PR creates a folder directly in the repository named "vlang", rather than placing it in the folder packages.

@TomJo2000
Copy link
Member

This PR seems close to actually being a merge-able build script for vlang.

Unfortunately, not quite yet - if you look closely, you can see that this PR creates a folder directly in the repository named "vlang", rather than placing it in the folder packages.

I wrote that review immediately after approving the CI runs, so I didn't see their status yet and then I was very surprised to see them "pass".

@TomJo2000 TomJo2000 added the help wanted Help is wanted in order to solve the issue label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Help is wanted in order to solve the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants