-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
scripts(toolchain): Update NDK to r29 #27089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| TERMUX_PKG_VERSION=28c | ||
| TERMUX_PKG_VERSION=29 | ||
| TERMUX_PKG_SRCURL=https://dl.google.com/android/repository/android-ndk-r${TERMUX_PKG_VERSION}-linux.zip | ||
| TERMUX_PKG_SHA256=59c2f6dc96743b5daf5d1626684640b20a6bd2b1d85b13156b90333741bad5cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TERMUX_PKG_SHA256 and some other content in these build.sh files is outdated/broken and doesn't currently work if TERMUX_ON_DEVICE_BUILD is true.
I have a PR here which fixes that,
however, the reason I didn't merge my PR yet is because,
I wanted some more feedback from the two users who are currently known to be actually affected by the errors the outdated build.sh content causes, about what priorities they have so I could try to orient any further changes towards their needs, but unfortunately neither of them have responded yet, in their issues:
- [Bug]: clang cannot compile for api levels other than default #23401
- [Bug]: libc++ download error #26838
Do you think I should go ahead and merge that PR before you merge this one, or would you want to copy the changes from it to this PR, or should I continue to hold off from merging it?
Other than any hypothetical requests that the users haven't asked for yet, the changes are ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think I should go ahead and merge that PR before you merge this one, or would you want to copy the changes from it to this PR, or should I continue to hold off from merging it?
Do what you think is best / easiest for you - this PR can be adapted later on if necessary!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will merge my PR in 24 hours, and then this PR can be rebased on it and I'll also test building this PR on-device after the rebase to make sure that its changes which work for NDK r28c also work for NDK r29.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have merged my PR now, which has caused this PR to have merge conflicts, but I hope it's not too much trouble to rebase this now.
OK, don't worry about it. I will bump Swift to 6.2 later this week and add back whatever I need then. 👍 |
See the r29 changelog - mostly a LLVM bump.
Known TODO:s
ndk-patches/28c/c++-v1-module.modulemap.patchandndk-patches/28c/c++-v1-stdlib.h.patchno longer applied and has been temporarily removed.