Skip to content

Conversation

@fornwall
Copy link
Member

@fornwall fornwall commented Nov 2, 2025

See the r29 changelog - mostly a LLVM bump.

Known TODO:s

  • The swift-specific C++ patches in ndk-patches/28c/c++-v1-module.modulemap.patch and ndk-patches/28c/c++-v1-stdlib.h.patch no longer applied and has been temporarily removed.
    • @finagolfin Can you have a look with adding the patches and test them?
  • Build more packages (have tested some random packages quickly, like imagemagick/dpkg/apt/bash/readline/ncurses/git/openssl/gtk4/qt6-qtbase/libgnutls/libllvm/rust/cmake/openssh/tmux/zsh/bash/python/python-numpy/perl/ruby/grep/ripgrep/postgresql/openssl/ffmpeg/imagemagick/tmux/weechat, and they all built fine without patches necessary).
  • Some on-device testing (have not done that yet).

@fornwall fornwall marked this pull request as draft November 2, 2025 23:50
TERMUX_PKG_VERSION=28c
TERMUX_PKG_VERSION=29
TERMUX_PKG_SRCURL=https://dl.google.com/android/repository/android-ndk-r${TERMUX_PKG_VERSION}-linux.zip
TERMUX_PKG_SHA256=59c2f6dc96743b5daf5d1626684640b20a6bd2b1d85b13156b90333741bad5cc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TERMUX_PKG_SHA256 and some other content in these build.sh files is outdated/broken and doesn't currently work if TERMUX_ON_DEVICE_BUILD is true.

I have a PR here which fixes that,

however, the reason I didn't merge my PR yet is because,

I wanted some more feedback from the two users who are currently known to be actually affected by the errors the outdated build.sh content causes, about what priorities they have so I could try to orient any further changes towards their needs, but unfortunately neither of them have responded yet, in their issues:

Do you think I should go ahead and merge that PR before you merge this one, or would you want to copy the changes from it to this PR, or should I continue to hold off from merging it?

Other than any hypothetical requests that the users haven't asked for yet, the changes are ready.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think I should go ahead and merge that PR before you merge this one, or would you want to copy the changes from it to this PR, or should I continue to hold off from merging it?

Do what you think is best / easiest for you - this PR can be adapted later on if necessary!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will merge my PR in 24 hours, and then this PR can be rebased on it and I'll also test building this PR on-device after the rebase to make sure that its changes which work for NDK r28c also work for NDK r29.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged my PR now, which has caused this PR to have merge conflicts, but I hope it's not too much trouble to rebase this now.

@finagolfin
Copy link
Member

The swift-specific C++ patches in ndk-patches/28c/c++-v1-module.modulemap.patch and ndk-patches/28c/c++-v1-stdlib.h.patch no longer applied and has been temporarily removed.
@finagolfin Can you have a look with adding the patches and test them?

OK, don't worry about it. I will bump Swift to 6.2 later this week and add back whatever I need then. 👍

@robertkirkman robertkirkman linked an issue Nov 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NDK r29 is now available

3 participants