-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
bump(main/gitea): 1.25.1 #27114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bump(main/gitea): 1.25.1 #27114
Conversation
|
This most likely won't be sufficient to update the |
@TomJo2000 The current environment is incompatible with pnpm compilation. Therefore, I leveraged the pre-built frontend package provided by Gitea as the source package, and the issue has now been resolved. |
|
I don't think that's a workable solution for us. |
@TomJo2000 Gitea switched from npm to pnpm in go-gitea/gitea#35274. The However, since Termux does not involve any frontend changes, it may be possible to skip the frontend compilation to save time. The pre-built frontend packages provided by Gitea are signed and do not pose a supply chain attack risk. An optional solution is to add support for initializing pnpm in |
55b15af to
e1a0dfc
Compare
| cp -a "$TERMUX_PKG_SRCDIR" "$GOPATH"/src/code.gitea.io/gitea | ||
|
|
||
| (cd "$TERMUX_PKG_SRCDIR" && npm install pnpm) | ||
| export PATH="$TERMUX_PKG_SRCDIR/node_modules/.bin:$PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to use these commands in termux_step_make() instead of termux_step_pre_configure() (where I tested them), you could probably also write them like this instead:
npm install pnpm
export PATH="$TERMUX_PKG_BUILDDIR/node_modules/.bin:$PATH"
however it doesn't really matter, I think either way is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertkirkman This can be considered a quick fix for now. Adding proper support for pnpm in a subsequent update would indeed be a better long-term solution. Thank you for the reminder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, what more would a termux_setup_pnpm need to do?
Maybe put pnpm in a "more proper" location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the assist Robert.
Gitea now uses pnpm for project compilation. Since the current environment does not support pnpm, we are using the prebuilt packages provided in Gitea's releases.
closes #27054