-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
new package: termux-netstore #28140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
new package: termux-netstore #28140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package appears to be written in Shell scripts (so would run just fine without patches or packaging) and has no existing history of packaging, or applicability outside of Termux.
We don't usually package shell scripts or Termux unique packages under the current packaging guidelines.
I've attached a copy of the package request checklist below.
Perhaps we should clarify the template to be more explicit about not usually packaging Termux specific utilities.
Packaging policy acknowledgement
-
[?] The project is actively developed.
-
The project has existing packages and is "well known".
-
Licensed under an open source license.
-
Not available through a language package manager: pip, npm, cpan, cargo, etc.
-
Not taking up too much disk space (< 100MiB per architecture, exceptions can be made)
-
Not duplicating the functionality of existing packages.
-
Not serving hacking, malware, phishing, spamming, spying, ddos functionality.
-
I certify that I have read Termux Packaging Policy and understand that my request will be denied if it is found lacking.
|
Thank you for the review, @TomJo2000! I understand the policy regarding shell scripts, but I'd like to present a case for why
While it is written in bash, it acts more like a system utility/manager than a simple script. Packaging it ensures users get all the correct dependencies (especially If this still falls outside the scope of the main repo, I understand and will look into hosting a personal repository. Thanks! |
|
I do understand why having a standard package would be useful for ensuring everything ends up where it needs to be. "Orchestrate" is a odd turn of phrase to describe packages dependencies. Nor will the CI be able to build the package if it cannot obtain the source tarball. |
|
Apologies for that! I have made the repository public now. Regarding 'orchestrate': I meant that it handles the conditional logic of ensuring all required tools are available (e.g., falling back to Please let me know if you are able to review the code now. |
|
I'm able to view the repository now. On a procedural note, please check your associated emails in your GitHub account settings. |
This PR adds a new package 'termux-netstore', a network storage manager for Termux.