Skip to content

Conversation

@lolbaj
Copy link

@lolbaj lolbaj commented Jan 23, 2026

This PR adds a new package 'termux-netstore', a network storage manager for Termux.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package appears to be written in Shell scripts (so would run just fine without patches or packaging) and has no existing history of packaging, or applicability outside of Termux.

We don't usually package shell scripts or Termux unique packages under the current packaging guidelines.
I've attached a copy of the package request checklist below.
Perhaps we should clarify the template to be more explicit about not usually packaging Termux specific utilities.

Packaging policy acknowledgement

  • [?] The project is actively developed.

  • The project has existing packages and is "well known".

  • Licensed under an open source license.

  • Not available through a language package manager: pip, npm, cpan, cargo, etc.

  • Not taking up too much disk space (< 100MiB per architecture, exceptions can be made)

  • Not duplicating the functionality of existing packages.

  • Not serving hacking, malware, phishing, spamming, spying, ddos functionality.

  • I certify that I have read Termux Packaging Policy and understand that my request will be denied if it is found lacking.

@lolbaj
Copy link
Author

lolbaj commented Jan 23, 2026

Thank you for the review, @TomJo2000! I understand the policy regarding shell scripts, but I'd like to present a case for why termux-netstore benefits from packaging:

  1. Dependency Management: It orchestrates a complex set of dependencies (openssh, rsync, nmap, mdns-scan) and specifically handles the "missing sshfs" situation in Termux by auto-configuring rclone as a fallback mount provider.
  2. Security & Configuration: It automates the secure setup of SSH servers (key generation, permission fixing for ~/.ssh, authorized_keys management) which is a common pain point and security risk for Termux users when done manually.
  3. Android Integration: It integrates with termux-api for notifications and clipboard operations, which requires specific environment checks.

While it is written in bash, it acts more like a system utility/manager than a simple script. Packaging it ensures users get all the correct dependencies (especially rclone and openssh) installed automatically, which curl | bash installers can't always guarantee cleanly.

If this still falls outside the scope of the main repo, I understand and will look into hosting a personal repository. Thanks!

@TomJo2000
Copy link
Member

TomJo2000 commented Jan 23, 2026

I do understand why having a standard package would be useful for ensuring everything ends up where it needs to be.

"Orchestrate" is a odd turn of phrase to describe packages dependencies.
I am unable to evaluate any of your other claims as the source repository still appears to be private.

Nor will the CI be able to build the package if it cannot obtain the source tarball.

@lolbaj
Copy link
Author

lolbaj commented Jan 23, 2026

Apologies for that! I have made the repository public now.

Regarding 'orchestrate': I meant that it handles the conditional logic of ensuring all required tools are available (e.g., falling back to rclone if sshfs is missing, which is a specific issue in the standard Termux environment).

Please let me know if you are able to review the code now.

@TomJo2000
Copy link
Member

I'm able to view the repository now.
Unfortunately I don't think this meets our packaging guidelines.

On a procedural note, please check your associated emails in your GitHub account settings.
It appears your commit email ([email protected]) is not associated to your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants