Nat Network Support #103
Open
Nat Network Support #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -0,0 +1,94 @@ | |||
| // This Source Code Form is subject to the terms of the Mozilla Public | |||
There was a problem hiding this comment.
I am absolutely not a lawyer, so I have no idea how any of this works, but this repository is licences under MIT, Can we just pull in another licence for a single file?
There was a problem hiding this comment.
That was copied from provider.go
Feel free to re-license under MIT.
VoyTechnology
requested changes
Jun 28, 2021
| return errLogf("unable to get nat network: %v", err) | ||
| } | ||
| if err := natnet.Config(); err != nil { | ||
| return errLogf("unable to remove nat network: %v", err) |
There was a problem hiding this comment.
This error message doesn't appear to be correct. We are updating the resource here, not deleting it.
| if err != nil { | ||
| return errLogf("unable to get nat network: %v", err) | ||
| } | ||
| if err := natnet.Config(); err != nil { |
There was a problem hiding this comment.
The updated values are not passed in anywhere, so I don't think the update will actually have the intended consequences.
Open
|
Bummer. NAT support isn't there yet. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #82 onto master and added documentation, as discussed in comment. Depends on the PR from go-virtualbox.