Skip to content

Conversation

@emidev98
Copy link
Contributor

@emidev98 emidev98 commented Feb 5, 2024

Defaults the label as "-" since empty string or undefined is not allowed and developers may not want to use a label

@javiersuweijie
Copy link
Member

Should we just throw an error? Since a label is required and it is up to the dev to pick one. If it defaults to - then it might be successful even though the dev didn't know that a label should be set.

Copy link
Member

@javiersuweijie javiersuweijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

Base automatically changed from feat/bank/supply_by_denom to main February 6, 2024 15:44
@emidev98
Copy link
Contributor Author

emidev98 commented Feb 6, 2024

Core will throw an error if the label is not set, so in order to make it easier for the dev that wants to setup a meaningless label we just default to "-" if the label is not provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants