feat: add Dataflow example for confidential compute#106
Open
guilherme-hosoda-cit wants to merge 2 commits intoterraform-google-modules:mainfrom
Open
Conversation
guilherme-hosoda-cit
requested review from
a team,
ayushmjain,
krprabhat-eng and
q2w
as code owners
erlanderlo
suggested changes
Mar 12, 2026
erlanderlo
left a comment
erlanderlo
left a comment
There was a problem hiding this comment.
thanks for your help with this! some comments to consider
| service_account_email = var.service_account_email | ||
| network_name = module.vpc.network_self_link | ||
| subnetwork = module.vpc.subnets_self_links[0] | ||
| use_public_ips = true |
| */ | ||
|
|
||
| module "example" { | ||
| source = "../../../examples/confidential_compute_example" |
There was a problem hiding this comment.
since this is already in the example direction, consider just calling this "confidential_computing" instead of "confidential_computing_example" unless there is an existing pattern for this.
| @@ -0,0 +1,82 @@ | |||
| # Copyright 2019 Google LLC | |||
| - name: "confidential_compute_example" | ||
| driver: | ||
| name: "terraform" | ||
| command_timeout: 1800 |
There was a problem hiding this comment.
maybe indicate the reasoning want to wait; perhaps because the workers need to spin up, as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new example on how to use the Dataflow module to configure jobs with Confidential Computing, providing an extra layer of security for data during processing.