feat(core_project_factor): enable setting a description for the default service account #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apeabody Could I get a review of this? Thanks! |
apeabody
changed the title
|
/gcbrun |
apeabody
requested changes
Jul 1, 2025
There was a problem hiding this comment.
Thanks for the contribution @FalconerTC!
Please run the make docker_generate_docs command and commit the above changes:
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/README.md /tmp/tmp.Lb8Vou0Hk7/generate_docs/workspace/README.md
156a157
> | project\_sa\_description | Description to set for the project default service account. | `string` | `null` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
|
/gcbrun |
apeabody
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable setting a description for the default service account in
core_project_factory. I am implementing an organization policy that requires our SA's have descriptions and we rely on this SA for new projects, so this minor feature request would help us there. The default is null to prevent changing existing resources.