feat:exposed visibility value for the provider in the DA #132
Conversation
|
/run pipeline |
…st SKIP UPGRADE TEST
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ibm_catalog.json
Outdated
| "key": "region", | ||
| "required": true, | ||
| "default_value": "us-south", | ||
| "options": [ |
There was a problem hiding this comment.
we are trying to stop using these custom picker for region, unless indeed the service itself is only supported in some regions. Looks like code engine is supported in all region, so please use this code:
{
"key": "region",
"type": "string",
"custom_config": {
"type": "region",
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"showKinds": [
"region"
]
}
}
}
There was a problem hiding this comment.
done 25cda97
|
/run pipeline |
There was a problem hiding this comment.
This is neither an approval or a request for changes. The original scope of the issue is growing, so should this be split to a new issue or resolved in this issue?
The description of variables in the apps solution needs some work, and/or a mark down written to explain the 6 compelx variables types in the DA.
There are examples of mark down, eg. ICD Postgresql in solution/standard/DA-types.md.
The lists and maps are fundamentally different things. The lists specifically belong to the app. The maps are other code engine resources. So there may be a hybrid answer from a DA perspective, it may be better to remove the maps from the apps DA and to include new DAs to cover them.
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
exposed visibility value for the provider in the DAs , with default value set to "private"
Git issue
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
exposes visibility value for the provider in the DA
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers