Conversation
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
| "ibmcloud_api_key": $VALIDATION_APIKEY, | ||
| "resource_group_name": $PREFIX, | ||
| "prefix": $PREFIX, | ||
| "project_names": [ |
There was a problem hiding this comment.
Ah this syntax is not supported. The variable substitution only works for strings right now. However you should be able to do this and it will add the prefix value to each project name right? So the validation wont have ant name clashes.
"project_names": "[\"project1\", \"project2\"]"
There was a problem hiding this comment.
A list of project names is required input. Is there another way of passing the values?
There was a problem hiding this comment.
That string will convert to a terraform list when passed to projects / schematics. Just like it does here
There was a problem hiding this comment.
@daniel-butler-irl you still need to update to "project_names": "[\"project1\", \"project2\"]" for this to work
ibm_catalog.json
Outdated
| } | ||
| }, | ||
| { | ||
| "label": "New Code Engine Projects", |
There was a problem hiding this comment.
Projects -> projects (I think @SirSpidey would request that :))
There was a problem hiding this comment.
🥇 for Conall.
LC projects, as you have at L143
|
/run pipeline |
solutions/projects/README.md
Outdated
| This deployable architecture creates IBM Cloud Code Engine projects and the following optional resources: | ||
|
|
||
| - A resource group. | ||
| - A Code Engine projects. |
There was a problem hiding this comment.
you already mention on line 3 that is creates code engine projects
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
You need to update .catalog-onboard-pipeline.yaml and add the new variation to it for catalog pipeline to import it
|
/run pipeline |
| install_type: fullstack | ||
| scc: | ||
| instance_id: 1c7d5f78-9262-44c3-b779-b28fe4d88c37 | ||
| region: us-south |
There was a problem hiding this comment.
you didnt include any compliance section in the ibm_catalog.json so these SCC details will not be used. This means that no SCC scan will be done, and the flavor wont show a compliance tab in the tile. If there is even 1 compliance rule that is applicable to code engine projects, we should probably add a compliance section to the ibm_catalog.json for this flavor, but I’ll create a follow up issue so we don't hold this PR up
|
@daniel-butler-irl still one items to address: https://github.com/terraform-ibm-modules/terraform-ibm-code-engine/pull/92/files#r1731537672 Also please note this comment |
|
/run pipeline |
|
🎉 This issue has been resolved in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
4 participants
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers