Fix terraform init, by limit the account-iam-resources module below v6.0

[browseman]

Recently began to observe the following error during terraform init:

╷
│ Error: Unreadable module subdirectory
│ 
│ The directory
│ .terraform/modules/rosa_cluster_classic.account_iam_resources.account_iam_role/modules/iam-assumable-role
│ does not exist. The target submodule modules/iam-assumable-role does not
│ exist within the target module.
╵

That's because in v6 of terraform-aws-iam (module) the iam-assumable-role is missing completely.

This is only a temporary fix until a proper review and update is done.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: browseman
Once this PR has been reviewed and has the lgtm label, please assign robpblake for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @browseman. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gdbranco]

/ok-to-test

[gdbranco]

@browseman please run make terraform-docs

[hunterkepley]

/retest-required

[openshift-ci]

@browseman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-gen	b0b54ef	link	true	/test verify-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hunterkepley]

@browseman I think the issue is that the version of terraform-docs which our testing environment runs is v0.17.0 but the newest version of terraform-docs has some differences.

Would you mind downgrading to v0.17.0 and rerunning that make command? Eventually we will upgrade this tool but the changes in the new version are minimal (even though they break things) so it's been put off some

[hunterkepley]

apologies for the late response here, we have very limited manpower on this set of repositories