Merge pull request #104 from mpalmerlee/fix-parse-error-not-a-function

fix #92 this.parseError is not a function
terraformer-js · May 15, 2024 · 536a86c · 536a86c
2 parents 738533d + 293723d
commit 536a86c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/wkt/src/wkt.js b/packages/wkt/src/wkt.js
@@ -7,6 +7,11 @@
 
 'SOURCE';
 
+// surface parsing errors to calling code https://github.com/zaach/jison/issues/218
+parser.yy.parseError = function (err) {
+  throw err;
+};
+
 function PointArray (point) {
   this.data = [point];
   this.type = 'PointArray';

diff --git a/packages/wkt/test/wkt.test.js b/packages/wkt/test/wkt.test.js
@@ -1035,3 +1035,16 @@ test('should parse a GEOMETRYCOLLECTION with ZM property', function (t) {
     }
   });
 });
+
+test('should fail with friendly error message when wkt is invalid', function (t) {
+  t.plan(1);
+
+  const input = 'POINT(30,10)';
+
+  try {
+    wktToGeoJSON(input);
+  } catch (err) {
+    const error = err.toString();
+    t.deepEqual(error, 'Error: Unable to parse: Parse error on line 1:\nPOINT(30,10)\n--------^\nExpecting \'DOUBLE_TOK\', got \'COMMA\'');
+  }
+});