Enabling axial expansion with detailed depletion #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterPSmith
changed the title
|
this looks good to me, but i think we need @albeanth to confirm that he thinks it will hit all his axial expansion corner cases |
jakehader
reviewed
Oct 18, 2024
albeanth
reviewed
Oct 21, 2024
albeanth
reviewed
Oct 21, 2024
armi/reactor/converters/axialExpansionChanger/axialExpansionChanger.py
Outdated
Show resolved
Hide resolved
…or and update testing
…nsByFactor and update testing" This reverts commit ee30c85.
…or and update testing
…owerDecay`) to depletion
|
bump |
albeanth
approved these changes
Nov 1, 2024
Co-authored-by: Tony Alberti <[email protected]>
albeanth
approved these changes
Nov 1, 2024
john-science
reviewed
Nov 1, 2024
john-science
reviewed
Nov 1, 2024
john-science
reviewed
Nov 1, 2024
| import collections | ||
| import os | ||
| import unittest | ||
| import copy |
There was a problem hiding this comment.
We could alphabetize these imports.
john-science
reviewed
Nov 1, 2024
Co-authored-by: John Stilley <[email protected]>
john-science
reviewed
Nov 1, 2024
john-science
reviewed
Nov 1, 2024
john-science
reviewed
Nov 1, 2024
john-science
reviewed
Nov 1, 2024
john-science
approved these changes
Nov 1, 2024
drewj-tp
added a commit
that referenced
this pull request
Nov 7, 2024
…u-rotate-with-pin-dep * zprince/component_flux_up: fix linting release notes Enabling axial expansion with detailed depletion (#1954) Improving error testing (#2004) Addressing reviewer comments for component pin mg fluxes Removing mystery coverage line from tests (#2003) beef up assertions resolve fixme org imports No need to recast strings to strings Finishing up the numProcessors -> nTasks conversion (#2002) Using one-block reactor for component flux test Supporting Python 3.13 (#1996) Removing SmartList & adding coverage (#1992) Update `copyOrWarn` and `getFileSHA1Hash` to account for directories (#1984) Removing broken plot (#1994) Adding unit tests for `CylindricalComponentsDuctHetAverageBlockCollection` (#1991) Allowing creation of partially heterogeneous assemblies for 1D XS model (#1949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Detailed depletion calculations currently do not allow for axial expansion as the untruncated isotope vector is saved at the block level. Since axial expansion needs the fuel component isotopic composition, some changes are made in the framework to support calculating and storing detailed depletion and the isotope vector at the component level.
detailedNDens,powerDecay, andpdensDecaydetailedNDenstochangeNDensByFactorWhy is the change being made?
To support downstream depletion upgrades.
Checklist
docfolder.pyproject.toml.