Avoid closing plots that are meant to be interactive. #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plt.show() options are intended for: 1. Interactive use on ipython or notebooks 2. Automated use during sphinx-gallery generation Running plt.show() followed by plt.close() prevents at least the 2nd use case from working, as seen in terrapower#1977. This change puts the close() only in the code branches that are expected to be run non-interactively, e.g. compute code. That allows the system to keep memory clear during big runs while still allowing interactive and gallery usage. Fixes terrapower#1977
ntouran
force-pushed
the
ntouran/fix-interactive-plotting
branch
from
ca91d53
to
cc2ff77
Compare
john-science
approved these changes
Oct 26, 2024
john-science
added
bug
drewj-tp
added a commit
that referenced
this pull request
Oct 29, 2024
* main: Fixing HexBlock docstrings (#1981) Removing a duplicate hex rotation impl tag (#1979) Avoiding closing plots that are meant to be interactive (#1978) Ensuring HexBlock.rotate updates child spatial locators (#1943) Add new memory runLog info to memoryProfiler.py (#1970) Fixing various doc build issues (#1974) Hiding sphinx-needs warnings during doc build (#1973) Fixing warnings in CLI startup (#1972)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
This change puts the close() only in the code branches that are expected to be run non-interactively, e.g. compute code. That allows the system to keep memory clear during big runs while still allowing interactive and gallery usage.
Fixes #1977
Why is the change being made?
The plt.show() options are intended for:
Running plt.show() followed by plt.close() prevents at least the 2nd use case from working, as seen in #1977.
Checklist
docfolder.pyproject.toml.