Update copyOrWarn and getFileSHA1Hash to account for directories
#1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Arrielle! Can you re-run the linters? Thanks! |
|
(working on some tests now + fixing some code, so this isn't quite ready yet) Update @john-science : it's ready for review. I have a few comments and questions for you. |
opotowsky
commented
Oct 30, 2024
opotowsky
changed the title
copyOrWarn to account for directoriescopyOrWarn and getFileSHA1Hash to account for directories
opotowsky
commented
Oct 30, 2024
opotowsky
commented
Oct 30, 2024
opotowsky
commented
Oct 30, 2024
john-science
approved these changes
Oct 30, 2024
drewj-tp
added a commit
that referenced
this pull request
Nov 7, 2024
…u-rotate-with-pin-dep * zprince/component_flux_up: fix linting release notes Enabling axial expansion with detailed depletion (#1954) Improving error testing (#2004) Addressing reviewer comments for component pin mg fluxes Removing mystery coverage line from tests (#2003) beef up assertions resolve fixme org imports No need to recast strings to strings Finishing up the numProcessors -> nTasks conversion (#2002) Using one-block reactor for component flux test Supporting Python 3.13 (#1996) Removing SmartList & adding coverage (#1992) Update `copyOrWarn` and `getFileSHA1Hash` to account for directories (#1984) Removing broken plot (#1994) Adding unit tests for `CylindricalComponentsDuctHetAverageBlockCollection` (#1991) Allowing creation of partially heterogeneous assemblies for 1D XS model (#1949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
copyOrWarncan now handle directories. This also includes an edit togetFileSHA1Hashso that it can handle directories too.Why is the change being made?
Sometimes a directory needs to be copied too. Let's give the directories the attention they deserve!
This supports a case setting downstream that is a directory, not a file path.
Checklist
docfolder.pyproject.toml.