Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing coverage cruft from test CI #2003

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

john-science
Copy link
Member

What is the change?

I removed some old coverage stuff from the unit test CI.

Why is the change being made?

This is a remnant from back when the "coverage" and "unit test" CI were the same GitHub Workflows. There was an awful lot of back and forth to move CI features around over the preceding months. And since this extra stuff doesn't hurt anything it was missed.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added cleanup Code/comment cleanup: Low Priority ci Related to continuous integration / github actions labels Nov 1, 2024
@john-science john-science merged commit 63e8a80 into main Nov 5, 2024
21 checks passed
@john-science john-science deleted the cleanup_unittest_cruft branch November 5, 2024 22:13
drewj-tp added a commit that referenced this pull request Nov 7, 2024
…u-rotate-with-pin-dep

* zprince/component_flux_up:
  fix linting
  release notes
  Enabling axial expansion with detailed depletion (#1954)
  Improving error testing (#2004)
  Addressing reviewer comments for component pin mg fluxes
  Removing mystery coverage line from tests (#2003)
  beef up assertions
  resolve fixme
  org imports
  No need to recast strings to strings
  Finishing up the numProcessors -> nTasks conversion (#2002)
  Using one-block reactor for component flux test
  Supporting Python 3.13 (#1996)
  Removing SmartList & adding coverage (#1992)
  Update `copyOrWarn` and `getFileSHA1Hash` to account for directories (#1984)
  Removing broken plot (#1994)
  Adding unit tests for `CylindricalComponentsDuctHetAverageBlockCollection` (#1991)
  Allowing creation of partially heterogeneous assemblies for 1D XS model (#1949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants