Skip to content

#116 ADD RFD on how we should handle old comments #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

#116 ADD RFD on how we should handle old comments #525

merged 1 commit into from
Jul 14, 2025

Conversation

schonfinkel
Copy link
Contributor

@schonfinkel schonfinkel commented Jun 3, 2025 •
edited
Loading

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (explain):
    • RFD

Checklist

  • I have read the contributing guidelines
  • The pull request title follows this format:
    ISSUE_NUMBER ACTION_TYPE Short description (e.g., 123 ADD Feature description)
  • I have added tests and documentation (if applicable)
  • My changes generate no new warnings/errors and do not break existing functionality

@schonfinkel schonfinkel moved this to In Progress in The Senate Jun 3, 2025
@schonfinkel schonfinkel self-assigned this Jun 3, 2025
@schonfinkel schonfinkel force-pushed the 116-ADD-rfd branch 6 times, most recently from 3204257 to 25f53ce Compare June 5, 2025 13:15
@schonfinkel schonfinkel marked this pull request as ready for review June 5, 2025 13:24
@schonfinkel schonfinkel requested a review from a team as a code owner June 5, 2025 13:24
@schonfinkel schonfinkel force-pushed the 116-ADD-rfd branch 4 times, most recently from 6894b00 to a53960c Compare June 5, 2025 21:13
orbitz
orbitz reviewed Jun 5, 2025
View reviewed changes
orbitz
orbitz reviewed Jun 5, 2025
View reviewed changes
orbitz
orbitz reviewed Jun 5, 2025
View reviewed changes
orbitz
orbitz reviewed Jun 6, 2025
View reviewed changes
@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

bender2352
bender2352 reviewed Jun 10, 2025
View reviewed changes
bender2352
bender2352 reviewed Jun 10, 2025
View reviewed changes
bender2352
bender2352 reviewed Jun 10, 2025
View reviewed changes
@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

orbitz
orbitz reviewed Jun 24, 2025
View reviewed changes
@terrateam-action Terrateam Action
Copy link

Plans ✖️

Outputs can be viewed in the Terrateam Console here.

Running plans FAILED. See Terrateam Plan Output.

After resolving the issue, run terrateam plan to execute the plan operation again.

Terrateam Plan Output ✖️

Expand for plan output details

Dir: rfds/116-Handling-Old-Comments | ✖️

Dir: rfds/116-Handling-Old-Comments
Workspace: default
Success: ✖️

Step: update-terrateam-github-token
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/rfds/bin/validate-state


Does not have mergable state

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

orbitz
orbitz reviewed Jun 24, 2025
View reviewed changes
orbitz
orbitz reviewed Jun 24, 2025
View reviewed changes
@orbitz
Copy link
Contributor

orbitz commented Jun 24, 2025

This revision looks good. I think at some point I would like to see some sort of description of the algorithm to handle Scenarios 0 - 2, as I believe that is what will be implemented in the first iteration of this and I suspect all 3 of those scenarios collapse into a single algorithm.

@schonfinkel schonfinkel linked an issue Jun 26, 2025 that may be closed by this pull request
Bootstrap a generic Comment module #561
Open
@schonfinkel
Copy link
Contributor Author

Work is being currently done in #562

@schonfinkel schonfinkel requested a review from orbitz July 10, 2025 20:04
@terrateam-action Terrateam Action
Copy link

Plans 👍

Outputs can be viewed in the Terrateam Console here.

Terrateam Plan Output 👍

Expand for plan output details

Dir: rfds/116 - Handling Old Comments | No changes

Dir: rfds/116 - Handling Old Comments
Workspace: default
Success: 👍

Step: plan
Success: 👍







To apply all these changes, comment:


terrateam apply






  
Feedback?


Questions? Comments? Give feedback by commenting terrateam feedback <your msg>.  Your message lands directly in our inbox.



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
          





        

  
      



  

  @terrateam-action

    
      Terrateam Action
    




  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        



  
    

      
          
Plans 👍


Outputs can be viewed in the Terrateam Console here.


Terrateam Plan Output 👍



  Expand for plan output details

Dir: rfds/116 - Handling Old Comments | No changes


Dir: rfds/116 - Handling Old Comments

Workspace: default

Success: 👍


Step: plan

Success: 👍








To apply all these changes, comment:


terrateam apply






  
Feedback?


Questions? Comments? Give feedback by commenting terrateam feedback <your msg>.  Your message lands directly in our inbox.



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
          





        

  
      



  

  @terrateam-action

    
      Terrateam Action
    




  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        



  
    

      
          
Plans 👍


Outputs can be viewed in the Terrateam Console here.


Terrateam Plan Output 👍



  Expand for plan output details

Dir: rfds/116 - Handling Old Comments | No changes


Dir: rfds/116 - Handling Old Comments

Workspace: default

Success: 👍


Step: plan

Success: 👍








To apply all these changes, comment:


terrateam apply






  
Feedback?


Questions? Comments? Give feedback by commenting terrateam feedback <your msg>.  Your message lands directly in our inbox.



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
          





        

  
      



  

  @terrateam-action

    
      Terrateam Action
    




  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        



  
    

      
          
Plans 👍


Outputs can be viewed in the Terrateam Console here.


Terrateam Plan Output 👍



  Expand for plan output details

Dir: rfds/116 - Handling Old Comments | No changes


Dir: rfds/116 - Handling Old Comments

Workspace: default

Success: 👍


Step: plan

Success: 👍








To apply all these changes, comment:


terrateam apply






  
Feedback?


Questions? Comments? Give feedback by commenting terrateam feedback <your msg>.  Your message lands directly in our inbox.



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
        





        

  
        





        

  
          





        

  
      



  

  @terrateam-action

    
      Terrateam Action
    




  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        



  
    

      
          
Plans 👍


Outputs can be viewed in the Terrateam Console here.


Terrateam Plan Output 👍



  Expand for plan output details

Dir: rfds/116 - Handling Old Comments | No changes


Dir: rfds/116 - Handling Old Comments

Workspace: default

Success: 👍


Step: plan

Success: 👍








To apply all these changes, comment:


terrateam apply






  
Feedback?


Questions? Comments? Give feedback by commenting terrateam feedback <your msg>.  Your message lands directly in our inbox.



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












        

  
          
 
  

    
  

  


        
        @schonfinkel
  schonfinkel



        merged commit 4a9e8e3
      into

      
  
    main
  


    Jul 14, 2025

      

        10 checks passed
      


      

        
  
          
  
    
    


  
      

  







    

    

      
    

    


      


          @github-project-automation
github-project-automation
bot



          moved this from Blocked On
  to Done
  in The Senate


      Jul 14, 2025

    

  



  

  
  

  
      @schonfinkel
  schonfinkel


    
    deleted the
    
      
        116-ADD-rfd
    
    branch

    July 14, 2025 18:02    
    











  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @orbitz
  
    orbitz



    
      
        
      
    
    orbitz approved these changes

  


      

          


  
      @bender2352
  
    bender2352


                Awaiting requested review from bender2352


        
      


      






    

  


      
  

    Assignees
  



        


      

        


  
      @schonfinkel
  
    schonfinkel
    

      








      


  


  

    Labels
  



    

      

    enhancement

  New feature or request








      

  

    

        

    Projects
  


        




        
  

    

      
          
        The Senate
        
    

    

      

            
    Status: Done

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  



            


Successfully merging this pull request may close these issues.



  
          
      Bootstrap a generic Comment module



  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @schonfinkel 
        
          @orbitz 
        
          @bender2352